Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New flake8 version raises new linting errors #747

Closed
armintaenzertng opened this issue Aug 17, 2023 · 1 comment
Closed

New flake8 version raises new linting errors #747

armintaenzertng opened this issue Aug 17, 2023 · 1 comment

Comments

@armintaenzertng
Copy link
Collaborator

With flake8 version 6.1.0, new linting errors appeared in the CI:

tests/spdx/parser/all_formats/test_parse_from_file.py:39:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
tests/spdx/parser/all_formats/test_parse_from_file.py:51:16: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
tests/spdx/parser/jsonlikedict/test_dict_parsing_functions.py:37:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`
tests/spdx/parser/jsonlikedict/test_dict_parsing_functions.py:46:12: E721 do not compare types, for exact checks use `is` / `is not`, for instance checks use `isinstance()`

These need to be fixed so that the CI comes out green again and other PRs can be merged.

@armintaenzertng
Copy link
Collaborator Author

fixed by #743

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant