Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using deprecated Buffer constructor #53

Closed
wants to merge 1 commit into from

Conversation

2 participants
@ChALkeR
Copy link

commented Mar 2, 2018

safe-buffer is already used and provides Buffer.alloc polyfill, so just use Buffer.alloc directly to avoid hitting deprecated API.

Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

Tracking: nodejs/node#19079

@ChALkeR ChALkeR force-pushed the ChALkeR:patch-1 branch from c52c8d1 to cf3378f Mar 2, 2018

Avoid using deprecated Buffer constructor
safe-buffer is already used and provides Buffer.alloc polyfill, so
just use Buffer.alloc directly to avoid hitting deprecated API.

Refs:
https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

@ChALkeR ChALkeR force-pushed the ChALkeR:patch-1 branch from cf3378f to 2c31bcc Mar 2, 2018

@jacobheun

This comment has been minimized.

Copy link
Contributor

commented Nov 8, 2018

I added this into the latest fixes for node LTS support #61 and it is available in spdy-transport@3.0.0

@jacobheun jacobheun closed this Nov 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.