feat: minimum viable spec in quickstart #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-timothy-albert
changed the title
ryan-timothy-albert
requested review from
ryan-timothy-albert
and removed request for
ryan-timothy-albert
ryan-timothy-albert
requested review from
ryan-timothy-albert
and removed request for
ryan-timothy-albert
ryan-timothy-albert
force-pushed
the
chase/filter-operations
branch
from
3565c15
to
735b3cc
Compare
simplesagar
approved these changes
May 8, 2024
ThomasRooney
approved these changes
May 8, 2024
| @@ -308,7 +316,20 @@ func (w *Workflow) runTarget(ctx context.Context, target string) (*sourceResult, | |||
| if source != nil { | |||
| sourcePath, sourceRes, err = w.runSource(ctx, rootStep, t.Source, target, false) | |||
| if err != nil { | |||
| return nil, err | |||
| if w.FromQuickstart && sourceRes != nil && sourceRes.LintResult != nil && len(sourceRes.LintResult.ValidOperations) > 0 { | |||
There was a problem hiding this comment.
nit: Might be cleaner to prompt the user first (do you want to retry with the successful parts of your spec: y/N) given this is an interactive flow.
…filter-operations
LukeHagar
pushed a commit
that referenced
this pull request
Jun 13, 2024
Co-authored-by: Ryan Albert <ryantimalbert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: https://github.com/speakeasy-api/openapi-generation/pull/1214
This implements minimum viable spec retries in quickstart. If a customers spec fails validation during run (in quickstart) we will best effort attempt to create an overlay for them of only minimum viable operations so they can get a working SDK.