Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise qrcode documentation #89

Merged
merged 8 commits into from Sep 14, 2017
+3 −3
Merged

Revise qrcode documentation #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5ec7c70
Create otpauth URL with issuer parameter in generateSecret() function
railsstudent Jan 17, 2017
3761613
Fixed the description in test case
railsstudent Jan 17, 2017
8c8624e
Create otpauth URL with issuer parameter in generateSecret() function
railsstudent Jan 17, 2017
6d9fddc
Add trailing whitespace back.
railsstudent Jan 17, 2017
99f2f71
Make the documentation of otpAuthURL consistent with code.
railsstudent Jan 17, 2017
a6f312f
Make the default value of otpAuthURL consistent with readme
railsstudent Jan 17, 2017
b751216
Merge conflict
railsstudent Mar 20, 2017
3b88323
Fix #88
railsstudent Jun 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Expand Up @@ -80,8 +80,8 @@ Next, we'll want to display a QR code to the user so they can scan in the secret
Use a QR code module to generate a QR code that stores the data in `secret.otpauth_url`, and then display the QR code to the user. This is one simple way to do it, which generates a PNG data URL which you can put into an `<img>` tag on a webpage:

```js
// Use the node-qrcode package
// npm install --save node-qrcode
// Use the qrcode package
// npm install --save qrcode
var QRCode = require('qrcode');

// Get the data URL of the authenticator URL
Expand Down
2 changes: 1 addition & 1 deletion test/generate.js
View file
Open in desktop
Expand Up @@ -117,7 +117,7 @@ describe('Generator tests', function () {
var secret = new Buffer(answer.base32, 'ascii');
if (Buffer.isBuffer(secret)) secret = base32.encode(secret);

var google_chart_url = 'https://chart.googleapis.com/chart?chs=166x166&chld=L|0&cht=qr&chl=';
var google_chart_url = 'https://chart.googleapis.com/chart?chs=166x166&chld=L|0&cht=qr&chl=';
var encodedOtpUrl = encodeURIComponent('otpauth://totp/Example%3Aalice%40google.com?secret=' + secret + '&algorithm=SHA1&digits=6&period=30');
var expect = google_chart_url + encodedOtpUrl;
assert.deepEqual(
Expand Down