Skip to content

Commit

Permalink
git-gui (Win): make "Explore Working Copy" more robust
Browse files Browse the repository at this point in the history
Starting the Explorer from the git-gui menu "Explore Working Copy"
didn't work, when git-gui was started via Windows Explorer shell
extension (Git GUI Here) from a directory within the project.
The Explorer raised an error message like this:

    Path "C:/somedir/worktree" is not available or not a directory

It worked when started from the project directory itself, because then
the path argument for the Explorer was just '.' (current directory)
without any problematic forward slashes.

To make it work, convert the path given as argument to explorer.exe to
its native format with backslashes.

Signed-off-by: Markus Heidelberg <markus.heidelberg@web.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
  • Loading branch information
marcows authored and spearce committed Apr 5, 2009
1 parent c949833 commit 454efb4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion git-gui.sh
Original file line number Original file line Diff line number Diff line change
Expand Up @@ -1947,7 +1947,7 @@ proc do_explore {} {
# freedesktop.org-conforming system is our best shot # freedesktop.org-conforming system is our best shot
set explorer "xdg-open" set explorer "xdg-open"
} }
eval exec $explorer [file dirname [gitdir]] & eval exec $explorer [list [file nativename [file dirname [gitdir]]]] &
} }
set is_quitting 0 set is_quitting 0
Expand Down

0 comments on commit 454efb4

Please sign in to comment.