Skip to content

Commit

Permalink
switch to firefox for playwright ci tests
Browse files Browse the repository at this point in the history
  • Loading branch information
spearwolf committed Jun 16, 2024
1 parent 257dc90 commit 0d9fe11
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 18 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@ jobs:
env:
NPM_TOKEN: xxx

- uses: browser-actions/setup-chrome@v1
with:
chrome-version: stable
- uses: browser-actions/setup-firefox@v1

- name: Run all checks
run: xvfb-run pnpm run ci
env:
CI: 1
NPM_TOKEN: xxx

- name: Upload twopoint5d-elements-e2e test-results artifacts
Expand Down
2 changes: 1 addition & 1 deletion packages/twopoint5d-elements-e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"three": "~0.165.0"
},
"devDependencies": {
"@playwright/test": "^1.38.1",
"@playwright/test": "^1.44.1",
"@types/three": "~0.165.0",
"autoprefixer": "^10.4.19",
"postcss": "^8.4.38",
Expand Down
28 changes: 15 additions & 13 deletions packages/twopoint5d-elements-e2e/playwright.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,23 +34,25 @@ export default defineConfig({

/* Configure projects for major browsers */
projects: [
{
name: 'chromium',
use: {
...devices['Desktop Chrome'],
headless: true,
},
},

{
name: 'firefox',
use: {...devices['Desktop Firefox'], headless: true},
},

{
name: 'webkit',
use: {...devices['Desktop Safari'], headless: true},
},
...(process.env.CI ? [] : [
{
name: 'chromium',
use: {
...devices['Desktop Chrome'],
headless: true,
},
},
{
name: 'webkit',
use: {...devices['Desktop Safari'], headless: true},
},
])
],

/* Test against mobile viewports. */
// {
Expand All @@ -71,7 +73,7 @@ export default defineConfig({
// name: 'Google Chrome',
// use: { ...devices['Desktop Chrome'], channel: 'chrome' },
// },
],
// ],

/* Run your local dev server before starting the tests */
webServer: {
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 0d9fe11

Please sign in to comment.