Merge pull request #136 from rafaelcaricio/fix_parameter_validation

Fixes problem with param validation

connexion/decorators/validation.py

@@ -11,6 +11,7 @@
  language governing permissions and limitations under the License.
 """
 
+import copy
 import flask
 import functools
 import itertools
@@ -133,6 +134,7 @@ def validate_parameter(parameter_type, value, param):
             except TypeValidationError as e:
                 return str(e)
 
+            param = copy.deepcopy(param)
             if 'required' in param:
                 del param['required']
             try:

tests/fakeapi/api.yaml

@@ -646,6 +646,16 @@ paths:
           in: query
           default: false
 
+  /test-required-param:
+    get:
+      summary: Test required param without default value
+      operationId: fakeapi.hello.test_required_param
+      parameters:
+        - name: simple
+          type: string
+          in: query
+          required: true
+
 definitions:
   new_stack:
     type: object

tests/fakeapi/hello.py

@@ -230,3 +230,7 @@ def test_formData_missing_param():
 
 def test_bool_default_param(thruthiness):
     return thruthiness
+
+
+def test_required_param(simple):
+    return simple

tests/test_app.py

@@ -600,3 +600,16 @@ def test_bool_as_default_param(app):
     assert resp.status_code == 200
     response = json.loads(resp.data.decode())
     assert response == True
+
+
+def test_required_param_miss_config(app):
+    app_client = app.app.test_client()
+
+    resp = app_client.get('/v1.0/test-required-param')
+    assert resp.status_code == 400
+
+    resp = app_client.get('/v1.0/test-required-param', query_string={'simple': 'test'})
+    assert resp.status_code == 200
+
+    resp = app_client.get('/v1.0/test-required-param')
+    assert resp.status_code == 400