Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve JSON req error on disallowed empty body (#1761)
Fixes #1152. Currently, when a request body is empty, the JSON request validator would parse it into None, which is later passed down to the JSON Schema validator. However, jsonschema's validation error message for this case (when nullable is false) "None is not of type 'object'" is not particularly friendly to either the API user, nor the website developer. This change adds a specific check before the None value is passed to jsonschema to emit a better error message directly. I also added some drive-by improvements on function argument typing since _validate in validators don't seem to expect receiving None, but _parse (the result of which is passed to _validate) is totally allowed to return None (or anything really). This does not seem to reflect the logic well. I’m not exactly sure if this is the best way to do this in Connexion 3.x. [We do have a patch in Connexion 2.x to achieve a similar effect](apache/airflow@e89a7ee) so if anyone understands how the two implementations correspond please tell me whether the two do the same thing 🙂 --------- Co-authored-by: Robbe Sneyders <robbe.sneyders@ml6.eu>
- Loading branch information