Bugfix/missing infofuncs #1375
Merged
Bugfix/missing infofuncs #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This situation occurs when a x-infoFunc is missing in the openapi document. Then this security scheme is skipped and the auth_funcs is an empty list if there are no other security schemes.
When the auth_funcs argument is the empty list, an AttributeError is raised because the token_info is None and does not have a 'get' attribute. This leads to a 500 error.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #869 , the check for
token_infowas changed fromif token_info is Nonetoif token_info is cls.no_value. However, the initial value fortoken_infoisNone, so if there are no auth_funcs (due to missingx-XXXInfoFuncs), theOAuthProblembranch isn't entered andtoken_info.get()will raise an AttributeError, leading to a 500 Internal Server Error.Changes proposed in this pull request:
token_infofromNonetocls.no_valueso that anOAuthProblemis raised