Add empty connexion middleware #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
reviewed
Mar 25, 2022
| """ | ||
| apps = [] | ||
| for middleware in reversed(middlewares): | ||
| app = middleware(app) |
There was a problem hiding this comment.
How can we add configuration to the different middlewares?
Typically, middleware can have additional keyword arguments, but it's not clear to me how we can do this here? (Unless with something like functools.partial)
There was a problem hiding this comment.
Indeed, currently functools.partial is probably the best way. Open to better options, but it might be hard without tying the implementation to specific middleware types.
I don't think we need to solve this now though. Once we get the internals working, we can still spend some time on the API we want to offer.
There was a problem hiding this comment.
Yes, just wanted to raise it to be aware of if there was a straightforward solution for it.
RobbeSneyders
commented
Mar 25, 2022
Ruwann
approved these changes
Mar 25, 2022
RobbeSneyders
force-pushed
the
feature/connexion-middleware
branch
from
7777cdc
to
cb4eaa6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally merged #1492 by rebasing on the wrong branch and pushing.
Reverted the previous merge, and opening this PR instead.