Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up operation classes #1535

Merged
merged 1 commit into from
May 13, 2022
Merged

Clean up operation classes #1535

merged 1 commit into from
May 13, 2022

Conversation

RobbeSneyders
Copy link
Member

This PR does some additional cleanup of the operation classes after we migrated the security functionality to middleware in #1514. Cleaned up some additional unused code as well.

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone May 10, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2302004445

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.08%) to 94.259%

Files with Coverage Reduction New Missed Lines %
connexion/spec.py 2 82.72%
Totals Coverage Status
Change from base Build 2270753938: -0.08%
Covered Lines: 2709
Relevant Lines: 2874

💛 - Coveralls

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a difference now between the Swagger2 operation and the OpenAPI operation, for the latter we keep the components while the former doesn't.

connexion/operations/swagger2.py Show resolved Hide resolved
Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

connexion/operations/swagger2.py Show resolved Hide resolved
@RobbeSneyders RobbeSneyders merged commit e0183d3 into main May 13, 2022
@RobbeSneyders RobbeSneyders deleted the feature/operation-cleanup branch May 13, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants