Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove built-in support for uWSGI #1544

Merged
merged 2 commits into from
May 24, 2022

Conversation

jacobstanly89
Copy link
Contributor

@jacobstanly89 jacobstanly89 commented May 24, 2022

Fixes #1530

Changes proposed in this pull request:

  • From connexion/operations/abstract.py,

Remove check for UWSGI metrics and to remove adding of the corresponding function decorator.

if UWSGIMetricsCollector.is_available(): # pragma: no cover decorator = UWSGIMetricsCollector(self.path, self.method) function = decorator(function)

Remove the following import

from ..decorators.metrics import UWSGIMetricsCollector

  • Delete the files tests/test_metrics.py and connexion/decorators/metrics.py

@jacobstanly89 jacobstanly89 changed the title Remove built-in support for uwsgi (#1530) Remove built-in support for uwsgi May 24, 2022
@jacobstanly89 jacobstanly89 changed the title Remove built-in support for uwsgi Remove built-in support for uWSGI May 24, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2375482539

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 94.338%

Totals Coverage Status
Change from base Build 2341371900: 0.06%
Covered Lines: 2649
Relevant Lines: 2808

💛 - Coveralls

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RobbeSneyders RobbeSneyders merged commit be492f9 into spec-first:main May 24, 2022
@jacobstanly89 jacobstanly89 deleted the remove_uwsgi branch May 24, 2022 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop builtin uWSGI support
3 participants