Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v2 to main #1579

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Merge v2 to main #1579

merged 4 commits into from
Aug 30, 2022

Conversation

RobbeSneyders
Copy link
Member

This PR herrypicks the changes on v2 to main.

rickpr and others added 4 commits August 29, 2022 18:10
* Fix OpenAPI parameters containing other parameters

OpenAPI parameters can be unspecified and sometimes contain other
parameters. The current behavior is to assume it's a bracket parameter
and nest the containing parameter within the contained parameter, which
breaks the schema as the original parameter now seems to contain a
nested object.

We can avert this by checking for the presence of a '[' in the
parameter.

* Trigger Github workflow

Co-authored-by: Ricardo Piro-Rael <rpiro-rael@ironox.com>
…d. (#1554)

Co-authored-by: Motti Lanzkron <motti@microfocus.com>
* fix: don't interpret simple parameter as deepObject

* Fix flake8 issues

Co-authored-by: Robbe Sneyders <robbe.sneyders@ml6.eu>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2950058849

  • 12 of 12 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 94.665%

Totals Coverage Status
Change from base Build 2910344107: 0.009%
Covered Lines: 2715
Relevant Lines: 2868

💛 - Coveralls

Copy link
Collaborator

@nielsbox nielsbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@RobbeSneyders RobbeSneyders merged commit 390c2e3 into main Aug 30, 2022
@RobbeSneyders RobbeSneyders deleted the feature/v2-to-main branch August 30, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants