Enable enforcing defaults #1616
Conversation
RobbeSneyders
force-pushed
the
feature/enforcedefaults
branch
2 times, most recently
from
a477bba
to
f4f4858
Compare
RobbeSneyders
changed the base branch from
main
to
feature/middleware-interface
|
I updated the PR with a solution that I think is a good middle ground. The standard I would have liked connexion to have an |
| @@ -63,7 +63,8 @@ def fn(self) -> t.Callable: | |||
| async def __call__( | |||
| self, scope: Scope, receive: Receive, send: Send | |||
| ) -> StarletteResponse: | |||
| return await self.fn(scope=scope, receive=receive, send=send) | |||
There was a problem hiding this comment.
Just a fix to get the AsyncApp working correctly. Not related to enforcing defaults, but necessary to make the example work.
| def __init__(self) -> None: | ||
| self.apis: t.Dict[str, AsyncApi] = {} | ||
| self.operations: t.Dict[str, AsyncOperation] = {} | ||
| self.router = Router() | ||
| super().__init__(self.router) | ||
|
|
||
| def add_api(self, *args, **kwargs): | ||
| api = AsyncApi(*args, **kwargs) | ||
| self.apis[api.base_path] = api | ||
| api = super().add_api(*args, **kwargs) |
There was a problem hiding this comment.
Just a fix to get the AsyncApp working correctly. Not related to enforcing defaults, but necessary to make the example work.
| while asyncio.iscoroutine(response): | ||
| response = await response | ||
| return response | ||
| return await decorated_function(request) |
There was a problem hiding this comment.
Just a fix to get the AsyncApp working correctly. Not related to enforcing defaults, but necessary to make the example work.
| api = self.api_cls(specification, next_app=self.app, **kwargs) | ||
| self.apis[api.base_path] = api | ||
| return api |
There was a problem hiding this comment.
Just a fix to get the AsyncApp working correctly. Not related to enforcing defaults, but necessary to make the example work.
| @@ -62,10 +62,10 @@ paths: | |||
| '201': | |||
| description: New pet created | |||
| requestBody: | |||
| x-body-name: pet | |||
| :return: A tuple (body, max_length) where max_length is the length of the larges message. | ||
| """ | ||
| more_body = True | ||
| max_length = 256000 |
There was a problem hiding this comment.
Where does this number come from? I'm not aware of an ASGI limit
There was a problem hiding this comment.
This is not constrained by ASGI, but by the server. I ran some tests with Uvicorn and this was the upper limit, although I couldn't find where this limit is defined.
connexion/validators/json.py
Outdated
| async def read_body(self) -> t.Tuple[str, int]: | ||
| """Read the body from the receive channel. | ||
|
|
||
| :return: A tuple (body, max_length) where max_length is the length of the larges message. |
RobbeSneyders
force-pushed
the
feature/enforcedefaults
branch
from
f4f4858
to
b64d494
Compare
Pull Request Test Coverage Report for Build 4015715852
💛 - Coveralls |
Pull Request Test Coverage Report for Build 4015715852
💛 - Coveralls |
This PR is a proposal to enforce defaults in json bodies.
I'm not sure which way to go here
defaultflag instead of the custom validator now needed.If we do want to go this way, we should probably implement a similar fix for form data, as we also use json validators there.