Pass through lifespan events #1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
reviewed
Mar 9, 2023
| @@ -46,3 +48,13 @@ def test_routing_middleware(middleware_app): | |||
| assert ( | |||
| response.headers.get("operation_id") == "fakeapi.hello.post_greeting" | |||
| ), response.status_code | |||
|
|
|||
|
|
|||
| async def test_lifecycle(): | |||
There was a problem hiding this comment.
This test fails on python 3.7 because AsyncMock is only availabe from Python 3.8.
We skip other tests relying on AsyncMock for Python 3.7
Suggested change
| async def test_lifecycle(): | |
| @pytest.mark.skipif( | |
| sys.version_info < (3, 8), reason="AsyncMock only available from 3.8." | |
| ) | |
| async def test_lifecycle(): |
Pull Request Test Coverage Report for Build 4386534208
💛 - Coveralls |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1672
Lifespan events were being intercepted by the swagger UI middleware. We should let them pass through.