Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for strict validation in combination with api key in query #1681

Merged

Conversation

Ruwann
Copy link
Member

@Ruwann Ruwann commented Apr 8, 2023

Continues on the work of #1077 by moving the test fixtures into the secure_endpoint fixture and adding a test for it in test_secure_api.py.

The test will check whether an api key in the query will not lead to an error when strict_validation is enabled.

@Ruwann Ruwann force-pushed the feature/apikey-query-strict-validation branch from 50c5eef to 542526b Compare April 8, 2023 22:43
@coveralls
Copy link

coveralls commented Apr 8, 2023

Pull Request Test Coverage Report for Build 4647463240

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 93.887%

Totals Coverage Status
Change from base Build 4646044651: 0.03%
Covered Lines: 3333
Relevant Lines: 3550

💛 - Coveralls

Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, glad to see some things move out of the simple app :)

Was this fixture just not used before?

@Ruwann
Copy link
Member Author

Ruwann commented Apr 20, 2023

Exactly, almost everything was there (fixture, swagger, view function) except an actual test and app with strict_validation enabled

@Ruwann Ruwann merged commit d9b699b into spec-first:main Apr 20, 2023
5 checks passed
@Ruwann Ruwann deleted the feature/apikey-query-strict-validation branch August 29, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants