Inspect middleware parameters before passing in lifespan #1686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
approved these changes
Apr 20, 2023
connexion/middleware/main.py
Outdated
| @@ -233,7 +234,11 @@ def _build_middleware_stack(self) -> t.Tuple[ASGIApp, t.Iterable[ASGIApp]]: | |||
| app = self.app | |||
| apps = [app] | |||
| for middleware in reversed(self.middlewares): | |||
| app = middleware(app, lifespan=self.lifespan) # type: ignore | |||
| arguments, has_kwargs = inspect_function_arguments(middleware) | |||
RobbeSneyders
force-pushed
the
bugfix/middleware-init-kwargs
branch
from
0689f96
to
9e044b9
Compare
Pull Request Test Coverage Report for Build 4774427774
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1682
This PR inspects the parameters of a Middleware class before passing in the
lifespankeyword argument. I was doubting to check the class instead (isinstance(LifespanMiddleware)), but that's less flexible if users want to write custom middleware to handle the lifespan.