Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack error handler when registering on middleware #1695

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

RobbeSneyders
Copy link
Member

Registering error handlers on the async app leads to an error on 3.0.0a5 because the error handlers are not unpacked correctly when being registered internally.

@RobbeSneyders RobbeSneyders added this to the Connexion 3.0 milestone Apr 24, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4787198260

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.841%

Totals Coverage Status
Change from base Build 4774497315: 0.2%
Covered Lines: 3337
Relevant Lines: 3556

💛 - Coveralls

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding a test!

@RobbeSneyders RobbeSneyders merged commit c3e2e57 into main Apr 24, 2023
5 checks passed
@RobbeSneyders RobbeSneyders deleted the bugfix/async_error_handler branch April 24, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants