Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context documentation #1747

Merged
merged 1 commit into from
Oct 22, 2023
Merged

Add context documentation #1747

merged 1 commit into from
Oct 22, 2023

Conversation

RobbeSneyders
Copy link
Member

@RobbeSneyders RobbeSneyders commented Oct 17, 2023

Contributes towards #1531

Fixes #937

@coveralls
Copy link

Coverage Status

coverage: 94.422%. remained the same when pulling 0923872 on feature/context-docs into 655ea43 on main.

Copy link
Member

@Ruwann Ruwann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

Although there is still the limitation in the security functions as the operation (specification) is not available there (which is mentioned in one of the comments)

@RobbeSneyders
Copy link
Member Author

Yes true. I'll add it to the security documentation.

We could make it available btw. The SecurityOperation that calls the security function has access to the Operation specification, as well as the other information we set as context variables.

We could either pass it into the security function directly, or set (and unset?) the context variables in each middleware, so code executed by the middleware has access to the context at that stage of the stack. Eg. custom validators would be able to use it as well. Let's discuss further in #1750

@RobbeSneyders RobbeSneyders merged commit 7eb43f1 into main Oct 22, 2023
7 checks passed
@RobbeSneyders RobbeSneyders deleted the feature/context-docs branch October 22, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attach operation specification to connexion.request
3 participants