Only instantiate specification once #1819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruwann
reviewed
Nov 29, 2023
| @@ -31,7 +32,7 @@ def __init__( | |||
| @classmethod | |||
| def from_operation( | |||
| cls, | |||
| operation: AbstractOperation, | |||
| operation: t.Union[AbstractOperation, Specification], | |||
There was a problem hiding this comment.
I don't immediately understand where this is coming from: why can this now be a Specification object as well? The variable name is pretty confusing now :)
There was a problem hiding this comment.
Yes, I understand it can be confusing 😅. This is because the security is defined both on the Operation and the Specification object, since it is defined at both these levels in the spec. For normal operations, the Operation is used. But for the add_auth_on_not_found, we create a dummy SecurityOperation based on the Specification.
I will add a comment explaining this.
examples/helloworld/hello.py
Outdated
| @@ -9,7 +9,7 @@ def post_greeting(name: str) -> str: | |||
|
|
|||
| app = connexion.FlaskApp(__name__, specification_dir="spec/") | |||
| app.add_api("openapi.yaml", arguments={"title": "Hello World Example"}) | |||
| app.add_api("swagger.yaml", arguments={"title": "Hello World Example"}) | |||
| # app.add_api("swagger.yaml", arguments={"title": "Hello World Example"}) | |||
There was a problem hiding this comment.
Remant from local testing?
Suggested change
| # app.add_api("swagger.yaml", arguments={"title": "Hello World Example"}) | |
| app.add_api("swagger.yaml", arguments={"title": "Hello World Example"}) |
RobbeSneyders
force-pushed
the
bugfix/instantiate-spec-once
branch
from
3393107
to
5a1e535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1801
I had to make quite a few additional changes to satisfy mypy.