Don't attempt to validate Response Streamed

[EmlynC]

If the response is of Response Streamed then get_data() throws a RuntimeError. Response streams are likely to be binary data so there is little need to validate these as it's out of the scope of Swagger validation.

Fixes #401.

[coveralls]

Coverage remained the same at 100.0% when pulling ef41835 on globalstressindex:master into 4403b66 on zalando:master.

[hjacobs]

Thanks for the PR! Please check the flake8 formatting, see https://travis-ci.org/zalando/connexion/jobs/242354204

[hjacobs]

Unit test would be appreciated too 😏

[EmlynC]

@hjacobs sure, I'll add unit tests, sorry for being lazy! We're TDD at Felix so there isn't really any excuses. I'll fix the PEP8 problems too and I'll add the commits to this current PR.

[hjacobs]

@EmlynC any update?

[EmlynC]

@hjacobs thanks for the prompt, I'll try and find some time today.

[gelineau]

Hi,
We are using connexion in our project. Thank you for making it open source.

The bug that this PR corrects is quite annoying for us. We would appreciate that the PR be merged.
Can I add the unit tests and PEP8 formatting that is missing ?
Should I modify this PR, or post a new PR ?

Thank you for your answer.

[EmlynC]

Wow, I dropped the ball here sorry @gelineau — I had said that we'd provide this ... about 8 months ago 😞

Please note that you can also bypass this check, by making sure the consumes and produces property of your endpoint in swagger is set to something other than application/json — in our case we set it to application/x-sqlite3. We ended up doing that and forgetting this PR, ultimately, coming back to this code it feels like it should throw a warning that asks "Are you trying to decode a JSON object or is this binary data?"e

I'm happy to add the unit tests and PEP fixes, let me find some time to get this fixed up today.

[kkthxbye]

Please note that you can also bypass this check, by making sure the consumes and produces property of your endpoint in swagger is set to something other than application/json

But response is built https://github.com/zalando/connexion/blob/master/connexion/decorators/response.py#L86
and response.get_data() crashes
https://github.com/zalando/connexion/blob/master/connexion/apis/flask_api.py#L203
before compatibility-based response validation skip
https://github.com/zalando/connexion/blob/master/connexion/decorators/response.py#L39
(called at https://github.com/zalando/connexion/blob/master/connexion/decorators/response.py#L87)

I guess that's because status code is needed in order to pick a schema from responses to validate response against.

Which means such a workaround doesn't work.

[hjacobs]

I'm closing this PR for now (as it's pretty old and there are no recent updates).

[gitttt]

There is no more consumes and produces in openapi 3.x. How do we solve this problem with openapi 3.x if we cannot use the mentioned workaround?