Handle non object body parameters #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There can be at most one body parameter according to the Swagger spec (http://swagger.io/specification/). I think getting the value from the body parsed as dict is wrong. |
| for key, value in body_parameters.items(): | ||
| if key not in arguments: | ||
| logger.debug("Body parameter '%s' not in function arguments", key) | ||
| if isinstance(body_parameters, dict): |
There was a problem hiding this comment.
I think getting the value from the body parsed as dict is wrong. 'There can be one "body" parameter at most.' the Swagger spec says.
There was a problem hiding this comment.
When connexion receives a request with type object body_parameters is a dict and I was getting the keys from inside that object and passing them to the function as arguments. Do you think it would be better to provide the body as a single argument in this case?
|
Looks better 👍 |
jmcs
added a commit
that referenced
this pull request
Sep 28, 2015
Handle non object body parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #66.