Fix for issue #975

[fr33mang]

Fixes #975 .

Changes proposed in this pull request:

• files added to aiohttp ConnexionRequest class

[hjacobs]

Can you add a test?

[fr33mang]

Can you add a test?

Can you help me with that?
The problem is in the aiohttp...

Schema

      summary: 'Test formData with file type, for file upload'
      operationId: fakeapi.aiohttp_handlers.test_formdata_file_upload
      consumes:
        - multipart/form-data
      parameters:
        - in: formData
          name: formData
          type: file
          description: The file to upload.
      responses:
        200:
          description: OK

Requests

resp = yield from app_client.post('/v1.0/aiohttp_test_formData_file_upload',
                        data={'formData': open('file.txt', 'rb')})   

data = FormData()
data.add_field('formData', open('file.txt', 'rb'), filename='file.txt')

resp = yield from app_client.post('/v1.0/aiohttp_test_formData_file_upload',
                        data=data)

Exception

ERROR    connexion.apis.aiohttp_api:aiohttp_api.py:85 Error handling request
Traceback (most recent call last):
  File "/connexion/connexion/apis/aiohttp_api.py", line 62, in problems_middleware
    response = yield from handler(request)
  File "/connexion/.env/lib/python3.7/site-packages/aiohttp/web_middlewares.py", line 110, in impl
    return await handler(request)
  File "/connexion/connexion/decorators/coroutine_wrappers.py", line 19, in wrapper
    connexion_request = yield from connexion_request
  File "/connexion/connexion/apis/aiohttp_api.py", line 282, in get_request
    data = yield from req.post()
  File "/connexion/.env/lib/python3.7/site-packages/aiohttp/web_request.py", line 597, in post
    field = await multipart.next()
  File "/connexion/.env/lib/python3.7/site-packages/aiohttp/multipart.py", line 538, in next
    await self._read_until_first_boundary()
  File "/connexion/.env/lib/python3.7/site-packages/aiohttp/multipart.py", line 604, in _read_until_first_boundary
    % (self._boundary))
ValueError: Could not find starting boundary b'--e85fae5ba3c048148a0736d5a7267cf2'

[prawn-cake]

@vasiliy-garenskikh
It looks like aiohttp related issue (or integration problem), I found some somewhat old issues:
aio-libs/aiohttp#1701
aio-libs/aiohttp#161

[fr33mang]

@vasiliy-garenskikh
It looks like aiohttp related issue (or integration problem), I found some somewhat old issues:
aio-libs/aiohttp#1701
aio-libs/aiohttp#161

The problem was in use this coroutine:
yield from req.post()
after this:
yield from req.read()

But I can't write aiohttp code to imitate HTML file upload form :(

Swagger:

 /aiohttp_test_formData_file_upload:  
    post:
      summary: 'Test formData with file type, for file upload'
      operationId: fakeapi.aiohttp_handlers.test_formdata_file_upload
      consumes:
        - multipart/form-data
      parameters:
        - in: formData  
          name: file_to_upload
          type: file
          required: true 
          description: The file to upload.
      responses:
        200:
          description: OK

file = open('file.txt', 'rb')

    data = FormData()
    data.add_field('file_to_upload',
            open('file.txt', 'rb'),
            filename='file.txt',
            content_type='multipart/form-data')

    with aiohttp.MultipartWriter('mixed') as mp:
        part = mp.append(file, {"Content-type": 'multipart/form-data'})
        part.set_content_disposition('file_to_upload', filename='secret.txt')

        resp = yield from app_client.post('/v1.0/aiohttp_test_formData_file_upload',
                        data=mp)
                        # data={'file_to_upload': (BytesIO(b'file contents'), 'filename.txt')})                        
                        # data=data)

But I get 400 status: file_to_upload field missed.

Do you know rigth way to send "file" html ?

[prawn-cake]

I haven't checked the codebase for a while, but I can assume that aiohttp files integration is missing
https://github.com/zalando/connexion/blob/master/connexion/apis/aiohttp_api.py#L281

Also there are currently few issues regarding multiform data
#954
#935

At first glance, I couldn't indentify where exactly the problem is.

[kornicameister]

As far as I can tell, this will never work.
If you post the request, whatever that is because important part is to have something in that, so the condition req_body_exists evaluates to True, you are reading the entire payload from aiohttp.web.Request in line 280 (yield from req.read()). Later on you are attempting to read the payload yet again via req.post(). That's why it fails.

What might have be needed is here is to distinguish between multipart requests and ordinary requests.
I assume that multipart requests might be processed in a way that we extract files and normal fields into separate variables and push'em into ConnexionRequest.

[prawn-cake]

Good catch!
Indeed, you can't read aiohttp.web.Request payload twice, since it's a StreamReader object and both methods read from it.
Calling different readers based on the content type sounds like a solution.

[kornicameister]

@prawn-cake Give it a whirl then :)

[kornicameister]

@prawn-cake I will give it a try on my own. We're interested in having it fixed as soon as possible.

[prawn-cake]

Thanks @kornicameister !
Sorry for not being very active here. I'll check the changes

[kornicameister]

@prawn-cake @vasiliy-garenskikh please check comment I left in a code. I cannot really tell if you noticed that as well, based on your conversation. I am just taking this form top of my head after checking aiohttp codebase

[kornicameister]

@prawn-cake @vasiliy-garenskikh I have created PR in my fork.
Currently I have achieved only single file upload via form-data.
I will expand the tests and behavior to multiple files as well as normal form data.

PR -> #987

cc @zawisz @hjacobs

[prawn-cake]

Cool. I left some comments there

[hjacobs]

I'm closing this PR for now (as it's pretty old, there are no recent updates, and no tests).