Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[das] updated for joint working group(s) and PP link #62

Merged
merged 4 commits into from
Mar 21, 2024

Conversation

himorin
Copy link
Contributor

@himorin himorin commented Mar 13, 2024

put review comments to w3c/deviceorientation#145

This is in WIP, please do not merge this now.

  • replaced 'Working Group' to 'Working Group(s)'
  • fixed dated PP link to non-dated one
  • fixed missing joint deliverable configuration in ED

@@ -40,16 +40,16 @@
<abbr title="World Wide Web Consortium">W3C</abbr> and its Members.
A Candidate Recommendation Snapshot has received <a
href="https://www.w3.org/2023/Process-20231103/#dfn-wide-review">wide review</a>, is intended to
gather implementation experience, and has commitments from Working Group members to <a
gather implementation experience, and has commitments from Working Group<span include-if="Text Macro: JOINT">s</span> members to <a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://en.wikipedia.org/wiki/Apostrophe#Possessive_apostrophe suggests we should say "Working Groups' members" i.e. add an apostrophe at the end:

Suggested change
gather implementation experience, and has commitments from Working Group<span include-if="Text Macro: JOINT">s</span> members to <a
gather implementation experience, and has commitments from Working Group<span include-if="Text Macro: JOINT">s'</span> members to <a

Disclaimer: I'm not a native speaker :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah,, text need to 'exactly' align with text in https://github.com/w3c/specberus/pull/1820/files ...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could some native speaker from the team check the newly added specberus language w3c/specberus#1820?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W3C comms were consulted and it seems both are correct so let's keep the current.

Copy link
Contributor

@anssiko anssiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some grammar suggestions.

@himorin himorin requested a review from anssiko March 21, 2024 12:54
@himorin himorin changed the title [WIP] [das] updated for joint working group(s) and PP link [das] updated for joint working group(s) and PP link Mar 21, 2024
@himorin
Copy link
Contributor Author

himorin commented Mar 21, 2024

added text for mail list of webapps. @anssiko @siusin

@himorin
Copy link
Contributor Author

himorin commented Mar 21, 2024

@tabatkins could you kindly check this and merge this PR?

@tabatkins
Copy link
Collaborator

Since this has been approved, I'll assume things are correct. If you need to make any fixes afterwards, feel free to open further PRs.

@tabatkins tabatkins merged commit cd1ee86 into speced:main Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants