Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default die-on value to the spec metadata #2623

Open
jyasskin opened this issue Jul 25, 2023 · 3 comments
Open

Add a default die-on value to the spec metadata #2623

jyasskin opened this issue Jul 25, 2023 · 3 comments

Comments

@jyasskin
Copy link
Collaborator

As mentioned in whatwg/meta#286 (comment), it'd be great for specs to be able to include their default --die-on value in their metadata. The fact that a spec is warning-clean is a property of the specification, so every build shouldn't have to remember to pass that argument.

@tabatkins
Copy link
Collaborator

Yeah, that sounds reasonable. It's a little bit of a layering violation since you can get errors before I even successfully parse the metadata, but that's fine, I'll just have to check if any errors have been emitted after metadata parsing is complete.

@inexorabletash
Copy link

It looks like maybe this happened in 82444e6

... but this issue isn't closed, and the docs weren't updated. Is there more to be done?

@tabatkins
Copy link
Collaborator

I need to fix up the docs, is all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants