Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/DevOps] Update Docker/CI configs to use Python3 #1611

Merged
merged 1 commit into from Mar 14, 2020
Merged

[CI/DevOps] Update Docker/CI configs to use Python3 #1611

merged 1 commit into from Mar 14, 2020

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Mar 14, 2020

The tests are failing on python3 branch as we are trying to run python3 programs on a python2.7 system. I have updated the Dockerfile and .travis.yml to correct this error.

Some updates are still required, needs discussion

@de-sh
Copy link
Contributor Author

de-sh commented Mar 14, 2020

Should we include 3.5, 3.5-dev, 3.6, 3.6-dev and 3.7-dev as well?

@tabatkins
Copy link
Collaborator

The tests are failing because I'm not done fixing errors and rebasing them, but yes, this is a necessary change as well. 😀

@tabatkins tabatkins merged commit 0967c12 into speced:python3 Mar 14, 2020
@de-sh
Copy link
Contributor Author

de-sh commented Mar 14, 2020

  File "/bikeshed-master/bikeshed/config/dfnTypes.py", line 50, in <module>
    dfnTypes = frozenset(dfnClassToType.values() + ["dfn"])
TypeError: unsupported operand type(s) for +: 'dict_values' and 'list'
The command '/bin/sh -c bikeshed update' returned a non-zero code: 1

This is an error I am trying to solve with the docker instance...

EDIT: How silly of me to be using python3 on master. It was there within the Dockerfile itself! 🤦‍♂️ 😂

Seems like it needs to be rewritten.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants