Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webperf status 2021 #2097

Merged
merged 2 commits into from Jul 20, 2021
Merged

Webperf status 2021 #2097

merged 2 commits into from Jul 20, 2021

Conversation

plehegar
Copy link
Contributor

This should align the documents with the latest W3C pubrules requirements.

Fixes https://github.com/w3c/paint-timing/runs/2955534035?check_suite_focus=true

Also removes the mention of the mailing list since webperf prefers GitHub anyway.

Hopefully, my use of [REPOSITORY] is proper.

cc @caribouW3 @yoavweiss

@plehegar
Copy link
Contributor Author

looks like an update of the tests from GitHub is needed to get the checks to be successful.

@plehegar
Copy link
Contributor Author

plehegar commented Jul 8, 2021

@tabatkins anything I can do to help push along?

@tabatkins
Copy link
Collaborator

To update tests, you can run bikeshed test --rebase. Or, if this is otherwise ready to be merged, I can do it myself.

@sideshowbarker
Copy link
Contributor

@plehegar I think one is waiting on your response to #2097 (comment):

To update tests, you can run bikeshed test --rebase. Or, if this is otherwise ready to be merged, I can do it myself.

@sideshowbarker
Copy link
Contributor

@plehegar I went ahead and ran bikeshed test --rebase locally and tried to push the resulting output to this branch — but git tells me I don’t have permissions to push to your branch.

So I instead put it at sideshowbarker@a42a1e0 — and you can pull that into your local clone of this PR branch with this:

git fetch git@github.com:sideshowbarker/bikeshed.git && git merge a42a1e02ba56b9a0e5a899976ea866ff0e9884c6

@tabatkins tabatkins merged commit 3e24225 into speced:main Jul 20, 2021
@tabatkins
Copy link
Collaborator

I've merged (and rebased tests myself) but I'll note that this changed the <h2 id=profile-and-date> back to id=subtitle; I was under the impression switching the ID was an intentional choice originally. Do you want to change it back?

@plehegar
Copy link
Contributor Author

sorry for dropping that ball. you guys rock!

@plehegar
Copy link
Contributor Author

Now sure about the ID. As long as pubrules is happy, I'm happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants