Autogenerate requirements.txt #2182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saschanaz
force-pushed
the
pipenv-lock
branch
from
628cb49
to
7dd642e
Compare
saschanaz
force-pushed
the
pipenv-lock
branch
from
7dd642e
to
312119f
Compare
saschanaz
force-pushed
the
pipenv-lock
branch
from
312119f
to
604a2c6
Compare
Dependabot will detect and update autogenerated requirements.txt. (dependabot/feedback#435 (comment)) It adds more requirements because those are what Pipfile.lock has. I think this can be ultimately be removed, since requirements.txt is not required if `pipenv` is used.
This is because the first commit here moved the editable self dependency to dev-packages, per the official pipenv recommendation: https://pipenv.pypa.io/en/latest/basics/#editable-dependencies-e-g-e That was done because otherwise the autogenerated requirements.txt also gets `-e .`, which is probably not wanted.
saschanaz
force-pushed
the
pipenv-lock
branch
from
604a2c6
to
b9f3983
Compare
|
Phew, finally took the time to understand what was happening here and merged it in. Thanks for the work, @saschanaz ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependabot will detect and update autogenerated requirements.txt. (dependabot/feedback#435 (comment), https://github.com/Taxel/PlexTraktSync/pull/533/files) It adds more requirements because those are what Pipfile.lock has.
(I think it can ultimately be removed, since requirements.txt is not required if
pipenvis used.)Fixes #2181