Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: switch to Node 16 (LTS) + update deps #3846

Merged
merged 11 commits into from
Nov 7, 2021
Merged

BREAKING CHANGE: switch to Node 16 (LTS) + update deps #3846

merged 11 commits into from
Nov 7, 2021

Conversation

marcoscaceres
Copy link
Contributor

@marcoscaceres marcoscaceres commented Oct 29, 2021 •
edited
Loading

For the dev server, macOS Monterey seems to claim port 5000 for itself for the "airplay" server.

marcoscaceres
marcoscaceres commented Oct 29, 2021
View reviewed changes
tools/release.js Outdated Show resolved Hide resolved
sidvishnoi
sidvishnoi reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@sidvishnoi sidvishnoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to check how it works with spec-prod first.

tools/release.js Outdated Show resolved Hide resolved
@sidvishnoi
Copy link
Member

And wow, taking port 5000 is a wild thing from mac.

@marcoscaceres
Copy link
Contributor Author

marcoscaceres commented Oct 29, 2021 •
edited
Loading

And wow, taking port 5000 is a wild thing from Mac.

I know :( I need to confirm that it's not something just running on my computer... but it only started yesterday after I did an OS update.

curl -i http://localhost:5000

Yields

HTTP/1.1 403 Forbidden
Content-Length: 0
Server: AirTunes/595.13.1

@sidvishnoi
Copy link
Member

sidvishnoi commented Nov 1, 2021 •
edited
Loading

I need to use Node 16 in spec-prod else yarn add respec fails. (GitHub Actions' Ubuntu 20/latest currently has Node 14 as default. I'll figure out something, need some time).

@sidvishnoi
Copy link
Member

spec-prod now uses Node 16. w3c/spec-prod#113.

@marcoscaceres marcoscaceres merged commit ee83e9c into develop Nov 7, 2021
@marcoscaceres marcoscaceres deleted the node_version branch November 7, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sidvishnoi sidvishnoi sidvishnoi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marcoscaceres @sidvishnoi @saschanaz