Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Automatic combinations don't match TW's rules for genera with nominotypical subgenera #3665

Open
dhobern opened this issue Nov 24, 2023 · 3 comments
Assignees
Labels
enhancement Suggest an improvement to an existing function.

Comments

@dhobern
Copy link

dhobern commented Nov 24, 2023

Steps to reproduce the bug

1. Create name with genus having a nominotypical subgenus as parent or with subgenus as parent
2. Select "Set as current" for original combination
3. TW creates original combination with genus set to reference the genus name not the nominotypical subgenus
4. TW then warns: "Relationship should move from genus Aus to subgenus Aus (Aus)"

Screenshot

No response

Expected behavior

If the relationship should be with the subgenus, it should be set that way automatically

Additional Screenshots

No response

Environment

Production

Sandbox Used

No response

Version

No response

Browser Used

Firefox

@dhobern dhobern added the bug An existing function is broken. label Nov 24, 2023
@typophyllum
Copy link

typophyllum commented Nov 24, 2023

I think if the author of the new species name doesn't care about subgenera, the original combination and rank would be Aus cus, independent of TW preferring to store the relationship at the lowest possible level.

@dhobern
Copy link
Author

dhobern commented Nov 27, 2023

@typophyllum You can certainly create subgenus-free names and combinations in TW, even in genera with subgenera. I was raising this issue to address the inconsistency in the internal processes and rules that TW applies. By default, it creates the combination with the genus as the name, but then it complains that the combination should be using the subgenus.

@proceps
Copy link
Contributor

proceps commented Nov 29, 2023

When we create a combination, we just use parent child relationships, at this stage, we do not know that coordinate subgenus exists in the database. The only thing which could be done is to soft_validate and fix of each of the TN relationships. It does not affect the spelling of the new combination. The soft_validation and fix was designed for future use, when we are able to run fixes on the entire project in order to optimize it.

@proceps proceps added enhancement Suggest an improvement to an existing function. and removed bug An existing function is broken. labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Suggest an improvement to an existing function.
Projects
None yet
Development

No branches or pull requests

3 participants