Wb Upload fails with field length error

[maxpatiiuk]

Describe the bug
Workbench fails with an error message like shown on the screenshot.
While the error message is genuine, it is supposed to be caught by the validator instead of being shown as an exception.

To Reproduce

1. Try to upload the attached data set

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots

Additional context
Data set: 0.tsv.zip

[maxpatiiuk]

I am on the wb-meta-refactor branch. It has uploader-memory-optimization merged into it and is rebased of next-release

Not sure if it is related, but I got another exception with this dataset:

specify7-specify7-worker-1  | [26/Oct/2021 14:07:59] [ERROR] [specifyweb.celery:30] Celery task failure!!!1
specify7-specify7-worker-1  | Traceback (most recent call last):
specify7-specify7-worker-1  |   File "/opt/specify7/ve/lib/python3.6/site-packages/celery/app/trace.py", line 405, in trace_task
specify7-specify7-worker-1  |     R = retval = fun(*args, **kwargs)
specify7-specify7-worker-1  |   File "/opt/specify7/ve/lib/python3.6/site-packages/celery/app/trace.py", line 697, in __protected_call__
specify7-specify7-worker-1  |     return self.run(*args, **kwargs)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/tasks.py", line 47, in upload
specify7-specify7-worker-1  |     do_upload_dataset(collection, uploading_agent_id, ds, no_commit, allow_partial, progress)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/upload.py", line 116, in do_upload_dataset
specify7-specify7-worker-1  |     base_table, upload_plan = get_ds_upload_plan(collection, ds)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/upload.py", line 205, in get_ds_upload_plan
specify7-specify7-worker-1  |     return base_table, plan.apply_scoping(collection)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/treerecord.py", line 31, in apply_scoping
specify7-specify7-worker-1  |     return apply_scoping(self, collection)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/scoping.py", line 179, in apply_scoping_to_treerecord
specify7-specify7-worker-1  |     disambiguation={},
specify7-specify7-worker-1  | TypeError: __new__() got an unexpected keyword argument 'root'
specify7-specify7-worker-1  | [2021-10-26 14:07:59,590: ERROR/ForkPoolWorker-1] Task specifyweb.workbench.tasks.upload[e342e724-caed-4bbd-a980-83b08de26bc1] raised unexpected: TypeError("__new__() got an unexpected keyword argument 'root'",)
specify7-specify7-worker-1  | Traceback (most recent call last):
specify7-specify7-worker-1  |   File "/opt/specify7/ve/lib/python3.6/site-packages/celery/app/trace.py", line 405, in trace_task
specify7-specify7-worker-1  |     R = retval = fun(*args, **kwargs)
specify7-specify7-worker-1  |   File "/opt/specify7/ve/lib/python3.6/site-packages/celery/app/trace.py", line 697, in __protected_call__
specify7-specify7-worker-1  |     return self.run(*args, **kwargs)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/tasks.py", line 47, in upload
specify7-specify7-worker-1  |     do_upload_dataset(collection, uploading_agent_id, ds, no_commit, allow_partial, progress)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/upload.py", line 116, in do_upload_dataset
specify7-specify7-worker-1  |     base_table, upload_plan = get_ds_upload_plan(collection, ds)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/upload.py", line 205, in get_ds_upload_plan
specify7-specify7-worker-1  |     return base_table, plan.apply_scoping(collection)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/treerecord.py", line 31, in apply_scoping
specify7-specify7-worker-1  |     return apply_scoping(self, collection)
specify7-specify7-worker-1  |   File "/opt/specify7/specifyweb/workbench/upload/scoping.py", line 179, in apply_scoping_to_treerecord
specify7-specify7-worker-1  |     disambiguation={},
specify7-specify7-worker-1  | TypeError: __new__() got an unexpected keyword argument 'root'

[benanhalt]

Yes I think this second exception is due to a merge issue. That root argument is something I had to add at the last minute to main WB branch after the optimization branch was split off. I'm not surprised there is some incompatibility there.

I will take a look that the field size exception.