Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxon author not displaying in the tree #1121

Closed
grantfitzsimmons opened this issue Dec 16, 2021 · 11 comments · Fixed by #2818
Closed

Taxon author not displaying in the tree #1121

grantfitzsimmons opened this issue Dec 16, 2021 · 11 comments · Fixed by #2818
Assignees
Labels
1 - Bug Incorrect behavior of the product
Milestone

Comments

@grantfitzsimmons
Copy link
Contributor

grantfitzsimmons commented Dec 16, 2021

Describe the bug
When Specify 6 has "Display Taxon Author in the tree view" checked in Preferences, the author of each taxon is displayed in the tree. In 7, this behavior is not replicated and there is no way to enable this.

To Reproduce
Steps to reproduce the behavior:

  1. Enable "Display Taxon Author in the tree view" in Specify 6.
    image
  2. View tree in 6 to verify this change was successful.
  3. View tree in 7.
  4. See error

Expected behavior
The author should display after each taxon entry.

Screenshots

sp6

sp7

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Edge
  • Specify 7 Version: 7.6.1

Reported By
Unitec

@grantfitzsimmons grantfitzsimmons added 1 - Bug Incorrect behavior of the product pri:unknown labels Dec 16, 2021
@maxpatiiuk maxpatiiuk added this to Unsorted in Trees via automation Jan 5, 2022
@maxpatiiuk maxpatiiuk moved this from Unsorted to To do in Trees Jan 14, 2022
@maxpatiiuk
Copy link
Member

maxpatiiuk commented Jan 14, 2022

For future reference:
The remotepref responsible for this is called TaxonTreeEditor.DisplayAuthor

Need to add a needed column to the response object created in this function:

def tree_view(request, treedef, tree, parentid, sortfield):

And then make front-end append the author name to node's name if needed

@grantfitzsimmons
Copy link
Contributor Author

grantfitzsimmons commented May 11, 2022

@maxpatiiuk Has this feature been added in the new release?

@maxpatiiuk
Copy link
Member

No, not yet

@benritchie
Copy link

what's the plan with this fix? It looks from the above like the fix is known, but it doesn't seem to be in 7.7?
Is it likely this change will be made?
Thanks.

@grantfitzsimmons
Copy link
Contributor Author

This has been requested by New Mexico, Unitec, and CSIRO. This should be addressed soon!

@grantfitzsimmons
Copy link
Contributor Author

Requested by @Schuchert at the Community Forum as well.

This is something that should be addressed soon!

Geneva, New Mexico, Unitec, and CSIRO have requested

@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/authors-of-taxon-names-in-sp7/937/5

@grantfitzsimmons
Copy link
Contributor Author

Requested by Heather Cole at Agriculture and Agri-Food Canada too.

This is something we need to prioritize.

@heathercole
Copy link
Contributor

heathercole commented Dec 21, 2022

Requested by Heather Cole at Agriculture and Agri-Food Canada too.

This is something we need to prioritize.

This is VITAL to our collection's quality-control and clean up of our tree (which is amazing in some taxo, and messy in others), particularly in botany where there can be multiple published names with different authors which reflect holdings in the collections. Tons of time lost clicking to view this basic info when there are taxa with the same names in the tree.

Even if hovering over the taxon meant that a pop-up would show the author would be helpful (like how the description of a field name is displayed when you hover over a field name)

@heathercole
Copy link
Contributor

my heroes!!!!!

will help so much with quality-control and management of the tree!!!!

image

@maxpatiiuk maxpatiiuk modified the milestones: 7.8.4, 7.8.5 Jan 31, 2023
@specifysoftware
Copy link

This issue has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-8-5-release-announcement/1023/1

@grantfitzsimmons grantfitzsimmons moved this from To do to Done in Priorities Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product
Projects
Trees
  
Shipped
Development

Successfully merging a pull request may close this issue.

8 participants