Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Clone, Add, and Save to the fullscreen resource editor #3768

Closed
grantfitzsimmons opened this issue Jul 12, 2023 Discussed in #3767 · 1 comment · Fixed by #3777
Closed

Add Clone, Add, and Save to the fullscreen resource editor #3768

grantfitzsimmons opened this issue Jul 12, 2023 Discussed in #3767 · 1 comment · Fixed by #3777
Assignees
Labels
1 - Request Improvements or extensions to existing behavior 2 - App Resources Issues that are related to app resources
Milestone

Comments

@grantfitzsimmons
Copy link
Contributor

Discussed in #3767

Originally posted by grantfitzsimmons July 11, 2023

How it looks now:

image

How it should look:

image

It's inconvenient to need to leave full screen, click save, then go back into full screen editing. The "Close" button is redundant since there is a fullscreen icon in the top level menu. It's logical to click the button you clicked to go full screen to minimize again.

@grantfitzsimmons grantfitzsimmons added 1 - Request Improvements or extensions to existing behavior 2 - App Resources Issues that are related to app resources labels Jul 12, 2023
@maxpatiiuk
Copy link
Member

I think this also fixes a UX problem with the current design: having just a Close button, and no Save button makes users feel like their changes won't be saved.

Also, the Close button was redundant with the full screen exit button.

I think we should definitely do the change you proposed, assuming it is not too difficult in the code (I don't remember the code, but probably the 3 buttons could just be assigned to a variable, and that variable could be put in a different place depending if you are in full screen or not)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Request Improvements or extensions to existing behavior 2 - App Resources Issues that are related to app resources
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants