Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loan/Gift preparations without count display as NaN on preparation selecting dialog #3881

Closed
bronwyncombs opened this issue Aug 1, 2023 · 4 comments · Fixed by #4006
Closed
Assignees
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Milestone

Comments

@bronwyncombs
Copy link

Describe the bug
If a preparation doesn't have a count entered, it will show as NaN in the Preparations dialog for loans and gifts. It is also falsely linked.

To Reproduce
Steps to reproduce the behavior:

  1. Create a CO, add preparation but leave count blank
  2. Create New Loan or Gift and enter Cat # for the CO record you made
  3. See error in Preparations selection dialog

Expected behavior
It should probably default to 1 in the available column and 0 for unavailable. Currently, you can add a preparation to the loan or gift without a count. Count isn't a required field, so this makes sense, but I'm not sure if we want that.
Screenshots

Screen.Recording.2023-08-01.at.9.27.55.AM.mov

Desktop:

  • macOS, Chrome, v7.9-dev

Database Name: archireef

@bronwyncombs bronwyncombs added 1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more labels Aug 1, 2023
@grantfitzsimmons
Copy link
Member

@bronwyncombs Can you see if this behavior happens on v7.8.13 as well? We can prioritize accordingly based on what you find 😄

@bronwyncombs
Copy link
Author

@grantfitzsimmons, it is

Screen.Recording.2023-08-14.at.10.38.51.AM.mov

@CarolineDenis
Copy link
Contributor

I'm wondering if I didn't fix that on the xml branch

@grantfitzsimmons
Copy link
Member

Screenshot 2023-09-07 at 10 22 28 PM

https://sbnature9523-v7813.test.specifysystems.org/specify/overlay/interactions/
https://sbnature9523-v79-dev.test.specifysystems.org/specify/overlay/interactions/

These preparations have no count (no value in the DB), so when creating a loan based on these records the count shown is "NaN". This should be changed to something intuitive to the user. NaN doesn't mean anything to non-programmers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Interactions Issues that are related to interactions, including loans, exchanges, gifts, and more
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants