Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable transparent background for Firefox #3460

Merged
merged 7 commits into from Sep 26, 2023
Merged

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3449

@CarolineDenis CarolineDenis marked this pull request as draft May 5, 2023 18:38
@CarolineDenis
Copy link
Contributor Author

It appears that the problem is related to compatibility issues with Firefox. Specifically, when attempting to apply backdrop-blur to the title, there is no visible effect. However, if backdrop-blur is applied to the node instead, the title becomes blurred behind the passing node when scrolling up. This suggests that there may be an issue with the z-index or that the effect needs to be applied to the child rather than the parent element. Further investigation will be necessary once Firefox has resolved its compatibility issues.

@CarolineDenis CarolineDenis requested review from a team and maxpatiiuk July 3, 2023 15:18
@CarolineDenis CarolineDenis marked this pull request as ready for review July 5, 2023 15:57
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good. will defer to others for design in light mode and dark mode

@CarolineDenis CarolineDenis added this to the 7.9.1 milestone Jul 10, 2023
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Screen.Recording.2023-07-17.at.9.35.36.AM.mov
Screen.Recording.2023-07-17.at.9.39.07.AM.mov

@CarolineDenis CarolineDenis merged commit e75f013 into production Sep 26, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3449 branch September 26, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove semi-transparent tree headings
4 participants