Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to sort fields in schema config by their hidden value #3516

Merged
merged 7 commits into from
Jun 2, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #2738

@CarolineDenis CarolineDenis requested a review from a team May 19, 2023 21:19
@carlosmbe
Copy link
Contributor

😅 Where exactly is the new sort option in the schema config?

@maxpatiiuk
Copy link
Member

Looking at the code, there should be a new checkbox below the list of fields in the schema config

@CarolineDenis
Copy link
Contributor Author

@carlosmbe
Screenshot 2023-05-22 at 2 27 57 PM

@carlosmbe
Copy link
Contributor

Thanks for the pointer Max and Caroline. Greatly appreciated <3
It works fine.
If I had a complaint it would be that it's a bit hard to tell the order initially(Descending vs Ascending)
And where the split between hidden and not hidden is

Copy link
Contributor

@carlosmbe carlosmbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It solves the issue #2738
But since it was an enhancement. I'm not sure if @grantfitzsimmons has any changes they'd like so I added them as a reviewer.

@maxpatiiuk
Copy link
Member

maxpatiiuk commented May 23, 2023

Yes, we should consider adding (hidden) to the names of fields that are hidden
And instead of "Sort by hidden field" which doesn't make sense from the user's perspective, how about "Visible fields first" or "Unhidden first"?
And make that checkbox be on by default
and store the value of the checkbox in localstorage so that it's preserved between sessions (look at how other checkboxes like this across specify are implemented)

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CarolineDenis
Copy link
Contributor Author

Yes, we should consider adding (hidden) to the names of fields that are hidden
And instead of "Sort by hidden field" which doesn't make sense from the user's perspective, how about "Visible fields first" or "Unhidden first"?
And make that checkbox be on by default
and store the value of the checkbox in localstorage so that it's preserved between sessions (look at how other checkboxes like this across specify are implemented)

After discussion, TODO:

  • add "hidden" to hidden fields
  • improve checkbox label
  • keep the rest as is

@CarolineDenis CarolineDenis merged commit 8e013e5 into xml-editor Jun 2, 2023
8 of 9 checks passed
@CarolineDenis CarolineDenis deleted the issue-2738 branch June 2, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants