Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to hide plus button in forms #3669

Merged
merged 8 commits into from
Jul 3, 2023
Merged

Conversation

CarolineDenis
Copy link
Contributor

@CarolineDenis CarolineDenis commented Jun 23, 2023

Fixes #3657

Testing instruction:
Editor form def in data entry
Add a queryComboBox the attribute newBtn=false
<cell type="field" id="4" name="cataloger" uitype="querycbx" initialize="name=Agent;title=Catalog Agent;newBtn=false" isrequired="true"/>
Verify the + button is now hidden

@CarolineDenis CarolineDenis changed the base branch from production to xml-editor June 23, 2023 17:53
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic is correct, except sp6 already has a property for this, so no need to add a new one.

(optional) Also, while you are at this, feel free to add support for other props too - #3657 (comment)

Finally, don't forget to update the forms Wiki page

@CarolineDenis CarolineDenis marked this pull request as ready for review June 26, 2023 17:54
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One big issue. The rest is good

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
(optional) it would be a good idea to also update the form parsing tests for query combo box to include these new attributes - that is not hard to do, but will prevent future bugs

Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Edited Determination form for the 'Determiner' QCB.
msedge_eZzmGG0kXc
msedge_7bjerLXwmY

@CarolineDenis CarolineDenis merged commit b0b15f7 into xml-editor Jul 3, 2023
8 of 9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3657 branch July 3, 2023 14:38
@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Jul 3, 2023

@maxpatiiuk can you remind me why we wanted this one to be merged with xml and not prod?

@maxpatiiuk
Copy link
Member

In general, avoid merging things to production unless it's urgent - every commit you merge is going to be more work for Alec or Jason later on due to merge conflicts (and of course, when resoling merge conflicts, bugs can be introduced)

But also, XML editing did changes to forms and form editing, so this was a better branch to do that change on.

If it is urgent to have this in production, feel free to cherry-pick the commits

@grantfitzsimmons grantfitzsimmons added this to the 7.9.3 milestone Nov 27, 2023
@specifysoftware
Copy link

This pull request has been mentioned on Specify Community Forum. There might be relevant details there:

https://discourse.specifysoftware.org/t/specify-7-9-4-release-announcement/1553/6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add the ability to hide QCBX buttons
5 participants