-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to hide plus button in forms #3669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logic is correct, except sp6 already has a property for this, so no need to add a new one.
(optional) Also, while you are at this, feel free to add support for other props too - #3657 (comment)
Finally, don't forget to update the forms Wiki page
specifyweb/frontend/js_src/lib/components/FormEditor/viewSpec.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One big issue. The rest is good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
(optional) it would be a good idea to also update the form parsing tests for query combo box to include these new attributes - that is not hard to do, but will prevent future bugs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxpatiiuk can you remind me why we wanted this one to be merged with xml and not prod? |
In general, avoid merging things to production unless it's urgent - every commit you merge is going to be more work for Alec or Jason later on due to merge conflicts (and of course, when resoling merge conflicts, bugs can be introduced) But also, XML editing did changes to forms and form editing, so this was a better branch to do that change on. If it is urgent to have this in production, feel free to cherry-pick the commits |
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-4-release-announcement/1553/6 |
Fixes #3657
Testing instruction:
Editor form def in data entry
Add a queryComboBox the attribute newBtn=false
<cell type="field" id="4" name="cataloger" uitype="querycbx" initialize="name=Agent;title=Catalog Agent;newBtn=false" isrequired="true"/>
Verify the + button is now hidden