Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow creating stat category without a name #3734

Merged
merged 1 commit into from Jul 10, 2023
Merged

Disallow creating stat category without a name #3734

merged 1 commit into from Jul 10, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3670

@CarolineDenis CarolineDenis requested review from melton-jason and a team July 6, 2023 16:41
@CarolineDenis CarolineDenis changed the base branch from production to v7.9-dev July 6, 2023 16:41
melton-jason
melton-jason approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works! 😃

@CarolineDenis CarolineDenis requested a review from a team July 7, 2023 20:01
bronwyncombs
bronwyncombs approved these changes Jul 7, 2023
View reviewed changes
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! The category name doesn't allow for a space to be the first (or only) character anymore. It still becomes red on attempted save when fully blank 👍

@CarolineDenis CarolineDenis merged commit 513f53d into v7.9-dev Jul 10, 2023
8 of 9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3670 branch July 10, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@melton-jason melton-jason melton-jason approved these changes

@bronwyncombs bronwyncombs bronwyncombs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can Create Blank Stats Category
4 participants
@CarolineDenis @maxpatiiuk @melton-jason @bronwyncombs