New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct form padding and round corners in Firefox #3827
Conversation
Fixes #3189 by modifying `scrollbar-gutter`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would heavily defer the decision to say this is a good change or not to @specify/ux-testing:
It is fine as far as the code is concerned, though maybe [scrollbar-gutter:auto]
might not be needed because it is the initial, default value. Need to look into this more, but it's not a bad decision to be declarative.
Maybe an approach like that taken in this StackOverflow answer may be worth considering as well
I can describe what these changes do, to give @specify/ux-testing a better idea on what to test.
scrollbar-gutter is a CSS property used to control how space is reserved for the scroll-bar.
We changed it from stable
to auto
.
Stable made it so that the space for the scroll-bar should have always been reserved, even if a scroll-bar is not needed.
Auto makes it so that space is only reserved for the scroll-bar when it is needed (when the contents are overflowing and we tell the browser to display a scrollbar)
See if these changes look okay on various screen widths: there should not be a drastic shifting of contents to accommodate a scroll-bar that is suddenly needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Screen.Recording.2023-07-24.at.10.41.33.AM.mov
Screen.Recording.2023-07-24.at.10.49.42.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scrollbar-gutter:auto
is the default value, so you can just remove that class name
scrollbar-gutter was useful at one point to reduce needless UI shifts (expand/collapse something inside the container or go between records), but if rounded corners are a bigger issue then ok
Also, perhaps edit:
(it sets both directions to scroll, for browsers that don't support overlay, but then overwrites that) thus removing scrollbar-gutter completely, or being explicit like @melton-jason suggested and leaving it there is fine |
Triggered by 29880e5 on branch refs/heads/issue-3189
Fixes #3189
Instructions to test:
It shouldn't look like this: