Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search box to splash screen #3835

Merged
merged 8 commits into from Sep 26, 2023
Merged

Add search box to splash screen #3835

merged 8 commits into from Sep 26, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3540

maxpatiiuk
maxpatiiuk requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job refactoring that into a component and changing styles appropriately

have one suggestion though

specifyweb/frontend/js_src/lib/components/HomePage/index.tsx Outdated Show resolved Hide resolved
grantfitzsimmons
grantfitzsimmons requested changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it this:
image

Instead of this:
image

@grantfitzsimmons grantfitzsimmons added this to the 7.9.1 milestone Jul 28, 2023
@grantfitzsimmons grantfitzsimmons requested a review from a team July 28, 2023 20:31
@grantfitzsimmons grantfitzsimmons requested a review from a team July 28, 2023 20:31
bronwyncombs
bronwyncombs approved these changes Jul 30, 2023
View reviewed changes
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Working as expected.

Screenshot 2023-07-30 at 9 06 37 AM

full screen:
Screenshot 2023-07-30 at 9 07 59 AM

@bronwyncombs
Copy link

The search box is sized differently across browsers. Could be expected but if it's not:

Screenshot 2023-07-29 at 11 25 47 PM

@carlosmbe
Copy link
Contributor

Does it have a toggle? For example, if a user prefers have a minimalist layout. Can they turn it off? (I am that user)

@CarolineDenis
Copy link
Contributor Author

Does it have a toggle? For example, if a user prefers have a minimalist layout. Can they turn it off? (I am that user)

We do not currently have a toggle, @grantfitzsimmons @melton-jason what is the general opinion for this option?

@grantfitzsimmons
Copy link
Contributor

I am OK with adding a pref, though it is not a priority.

@CarolineDenis CarolineDenis requested a review from a team August 3, 2023 15:41
@CarolineDenis CarolineDenis linked an issue Aug 21, 2023 that may be closed by this pull request
Add search box to home page #3540
Closed
Base automatically changed from v7.9-dev to production September 25, 2023 18:42
@CarolineDenis CarolineDenis merged commit 4bc3c61 into production Sep 26, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3540 branch September 26, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@bronwyncombs bronwyncombs bronwyncombs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.1
Development

Successfully merging this pull request may close these issues.

Add search box to home page
6 participants
@CarolineDenis @bronwyncombs @carlosmbe @grantfitzsimmons @maxpatiiuk @melton-jason