Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clear all button in notifications #3893

Merged
merged 11 commits into from Sep 29, 2023
Merged

Add clear all button in notifications #3893

merged 11 commits into from Sep 29, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3890

@CarolineDenis CarolineDenis linked an issue Aug 2, 2023 that may be closed by this pull request
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few things in addition to what Jason mentioned

Copy link
Contributor

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good now!

@CarolineDenis CarolineDenis requested a review from a team August 3, 2023 20:06
@grantfitzsimmons grantfitzsimmons added this to the 7.9.1 milestone Aug 7, 2023
Copy link
Contributor

@carlosmbe carlosmbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put somewhere more easily noticeable. Like parallel the close button or on top. Otherwise, it's a bit hard to notice.

Copy link
Contributor

@carlosmbe carlosmbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's only one notification. We shouldn't have the button. Otherwise, it seems great.

Edit:

There seems to be lingering notification that only leaves after opening up the notifications overlay

Screen.Recording.2023-08-25.at.4.26.32.PM.mp4

@grantfitzsimmons grantfitzsimmons changed the base branch from v7.9-dev to production September 26, 2023 02:41
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Could we make it less wide and add this to the bottom left of the dialog, in-line with the Close button?
  • It should be tied to button color preferences, maybe as a "Secondary"?
  • Do we think it's consistent to keep this as a button that's highlighted when scrolled over?
  • Could we also remove the slight border on the top?
Screen.Recording.2023-09-27.at.9.27.25.AM.mov

@CarolineDenis CarolineDenis merged commit ecc107a into production Sep 29, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3890 branch September 29, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Clear All Notifications Button
6 participants