New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add clear all button in notifications #3893
Conversation
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few things in addition to what Jason mentioned
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good now!
specifyweb/frontend/js_src/lib/components/Header/Notifications.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put somewhere more easily noticeable. Like parallel the close button or on top. Otherwise, it's a bit hard to notice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's only one notification. We shouldn't have the button. Otherwise, it seems great.
Edit:
There seems to be lingering notification that only leaves after opening up the notifications overlay
Screen.Recording.2023-08-25.at.4.26.32.PM.mp4
Triggered by 6c161db on branch refs/heads/issue-3890
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Could we make it less wide and add this to the bottom left of the dialog, in-line with the Close button?
- It should be tied to button color preferences, maybe as a "Secondary"?
- Do we think it's consistent to keep this as a button that's highlighted when scrolled over?
- Could we also remove the slight border on the top?
Fixes #3890