Add a max width for the side menu in security #3914
Conversation
Untitled.mov |
There was a problem hiding this comment.
Not the greatest fan of these breakpoints. I feel like they promote the use of magic numbers.
(It doesn't help that breakpoints themselves are magic numbers of common pixel widths).
Regardless, I can not deny that this does look better on narrow screens when the screen is "crowded".
However, when the screen is not "crowded", there seems to be a significant amount of jittering near the breakpoint.
Below are videos for how this is currently in v7.9-dev as well as the behavior for this current branch.
@specify/ux-testing Let me know what your thoughts are on this.
v7.9-dev:
v7.9-dev.mp4
v7.9-dev_tight.mp4
This branch (issue-3905):
issue-3905.mp4
issue-3905_tight.mp4
|
Based on the videos Jason provided. I prefer how this branch handles the Tight situations but prefer how the normal situation was handled previously. Is there a way to have both? |
Triggered by 61b9f2c on branch refs/heads/issue-3905
CarolineDenis
changed the title
There was a problem hiding this comment.
Looks good to me. I prefer this change in both "normal" and "tight" situations.
The magic number discussion is interesting– but I think the solution works fine. I'll leave it to you @melton-jason to suggest revisions if you see fit.
Triggered by 9c156b2 on branch refs/heads/issue-3905
Fixes #3905