New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow having tree stats use direct rank names (and climb tree) #3942
Conversation
The query that fetches ranks is done only one time. Since tree ranks are fetched outside of stats already, those could also be used instead of this. But stats like type status utilizes this too (it fetches distinct type status) so I thought it would be simple enough to just have the taxa ones utilize this in the stats spec. Alternatively, won't be hard to use the tree tank promise outside of stats here instead of fetching them again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have missed the context behind some of the changes you did as I am not familiar with the code much (and you created a beast with the stats page), but looking good, and I like some of the refactoring you did
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would take me too long to fully understand how Statistics works to fully consider these changes, but from what I am gathering from this little section, the changes seem fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Geog rank stats appeared in the choose stats dialog to be added to a new category. The queries for each rank appear correct. Upon clicking a stat on herb_rbge_9_3_23
, the query results were returned promptly, but count was slightly delayed.
Geo represented:
Localities without Distinct:
Also tested on fwri
@realVinayak Seems there are some merge conflicts |
Also need to test performance on AWS |
Can this be tested another time by a ux-reviewer before merge? @specify/ux-testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request has been mentioned on Specify Community Forum. There might be relevant details there: https://discourse.specifysoftware.org/t/specify-7-9-2-release-announcement/1452/1 |
Allows defining a query like 'geography.Country'. Looks for name in the {TREE}treedefitem table.
The previous code allowed just to modify the start values in the last query field, but these changes allow them to be generic.
TO TEST:
Change 2:
Removes distinct from locality stat