Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove contractions in error message #3978

Merged
merged 5 commits into from Sep 29, 2023
Merged

Remove contractions in error message #3978

merged 5 commits into from Sep 29, 2023

Conversation

grantfitzsimmons
Copy link
Contributor

Fixes #3977

@grantfitzsimmons grantfitzsimmons changed the base branch from production to v7.9-dev September 6, 2023 19:06
@grantfitzsimmons grantfitzsimmons added this to the 7.9.1 milestone Sep 6, 2023
maxpatiiuk
maxpatiiuk approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #3977 (comment)

otherwise good

other translations in here don't have contractions (mostly because other languages don't have contractions 😊)

@grantfitzsimmons grantfitzsimmons modified the milestones: 7.9.1, 7.9 Sep 11, 2023
@grantfitzsimmons grantfitzsimmons changed the base branch from v7.9-dev to production September 26, 2023 02:27
@grantfitzsimmons grantfitzsimmons merged commit 8f82362 into production Sep 29, 2023
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-3977 branch September 29, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.1
Development

Successfully merging this pull request may close these issues.

Change error message text to remove contractions
3 participants
@grantfitzsimmons @maxpatiiuk @CarolineDenis