Add ability to show only collection applicable nodes in tree

[CarolineDenis]

Fixes #2051

[maxpatiiuk]

Overal good, but in the future I would discourage you from making changes to the same component at the same time in different PRs (this and split tree) - that causes merge conflicts, which are not fan to resolve

[CarolineDenis]

@grantfitzsimmons , when you have time could you take a look at this PR on the test panel please?

[bronwyncombs]

With the checkbox selected, the tree still shows nodes that don't have associated objects.

Screen.Recording.2023-10-02.at.10.22.58.AM.mov

URL

[realVinayak]

@bronwyncombs they are different queries, that's why the result are different. the tree count in tree viewer check for preferred taxon. The query builder (the one you opened in new tab), checks for taxon.

[realVinayak]

Can this also be tested on some bigger trees like herb_rbge?

[realVinayak]

Based on #2051, looks like collections want to hide phylums (which is a very high rank). A bit concerned about performance since the query will be more expensive for it. Would need to have performance testing for it. @grantfitzsimmons do you know any other institutions which requested this, on which we can test?

If it becomes a problem,

1. Merge changes with Begin adding recursive CTE to tree queries #3613
2. Or make a faster query. In this case, this is possible. Because you don't care how many nodes a particular node, you can modify the stats end-point to use an exists() clause to the sql generated. This would be faster (likely a LOT) since MySQL is smart enough to do a semi-join https://dev.mysql.com/doc/refman/8.0/en/semijoins.html

[grantfitzsimmons]

Conclusion: Make this run queries on the entire tree once Vinny's count query rework is implemented.

Moving to v7.9.2

[pashiav]

issue-2051.mov

Nodes with count 0 are hidden when box is checked. Looks good!

[grantfitzsimmons]

@CarolineDenis Can this be in 7.9.3?

[grantfitzsimmons]

2. In the trees, a button for quick filtering of only the nodes with any associated collection object (as indicated by the number in parentheses near the nodes).

Requested By: Eyal at The Hebrew University of Jerusalem

[emenslin]

Works as expected, looks good.

20231220133522.mp4

[grantfitzsimmons]

Conclusion: Make this run queries on the entire tree once Vinny's count query rework is implemented.

We still haven't implemented this yet, right? In @emenslin's video, counts aren't showing for every node in the tree. I still see this as a requirement (as discussed in our group weeks ago).

[grantfitzsimmons]

After meeting with @CarolineDenis today, I feel the current implementation is satisfactory. While there may be a request in the future to run the count for all nodes, the behavior is understandable and resolving it is easy. I need to make a note in the documentation before release to clarify behavior to the users.

⚡ Nice work!! Thanks for talking with me about it @CarolineDenis 😄

fixed