New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add warning dialog when no prep available in disposal #4030
Conversation
Triggered by 6e4573c on branch refs/heads/issue-2881-noPrep
Triggered by ae37468 on branch refs/heads/issue-3297
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, but given that interactions code is tricky, buggy, legacy, and doesn't contain tests, I would encourage someone to test the InteractionDialog in all scenarios where it's used after this change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same situation as Loans/Gifts
After discussion with @grantfitzsimmons ; Expected behavior:
|
Triggered by a3dfd82 on branch refs/heads/issue-3297
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Disposal Preps and Loans.
Passed the following:
If cat # entered with no prep: warning message below the entry box 'This cat # has no prep' + possibility to continue without prep OR to update it
If cat # entered with prep: goes to new dialog with prep available / unavailable table
If cat # entered with prep and cat # without entered: warning message below the entry box 'This cat # has no prep' for the concerned cat # + possibility to continue => continue will bring to the new dialog with prep available / unavailable table with only the cat # containing preps
Fixes #3297