Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning dialog when no prep available in disposal #4030

Merged
merged 9 commits into from Sep 28, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #3297

Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but given that interactions code is tricky, buggy, legacy, and doesn't contain tests, I would encourage someone to test the InteractionDialog in all scenarios where it's used after this change

@CarolineDenis CarolineDenis requested a review from a team September 21, 2023 13:40
@CarolineDenis CarolineDenis marked this pull request as ready for review September 21, 2023 13:40
@CarolineDenis CarolineDenis added this to the 7.9.1 milestone Sep 21, 2023
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same situation as Loans/Gifts

#3936 (review)

@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Sep 28, 2023

After discussion with @grantfitzsimmons ;

Expected behavior:

  • If cat # entered with no prep: warning message below the entry box 'This cat # has no prep' + possibility to continue without prep OR to update it
  • If cat # entered with prep: goes to new dialog with prep available / unavailable table
  • If cat # entered with prep and cat # without entered: warning message below the entry box 'This cat # has no prep' for the concerned cat # + possibility to continue => continue will bring to the new dialog with prep available / unavailable table with only the cat # containing preps
    @carlosmbe @bronwyncombs
    please consider for testing.
    The tests on this branch should include Add warning dialog when no prep available #3936

Triggered by a3dfd82 on branch refs/heads/issue-3297
@carlosmbe carlosmbe self-requested a review September 28, 2023 20:43
Copy link
Contributor

@carlosmbe carlosmbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested Disposal Preps and Loans.

Passed the following:

If cat # entered with no prep: warning message below the entry box 'This cat # has no prep' + possibility to continue without prep OR to update it
If cat # entered with prep: goes to new dialog with prep available / unavailable table
If cat # entered with prep and cat # without entered: warning message below the entry box 'This cat # has no prep' for the concerned cat # + possibility to continue => continue will bring to the new dialog with prep available / unavailable table with only the cat # containing preps

@CarolineDenis CarolineDenis changed the base branch from issue-2881-noPrep to production September 28, 2023 20:45
@CarolineDenis CarolineDenis changed the base branch from production to issue-2881-noPrep September 28, 2023 20:56
@CarolineDenis CarolineDenis changed the base branch from issue-2881-noPrep to production September 28, 2023 20:57
@CarolineDenis CarolineDenis merged commit 5729536 into production Sep 28, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-3297 branch September 28, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disposal Preparation can be created when Collection Object has no Preparations
5 participants