Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add founding partners to the about dialog #4040

Merged
merged 3 commits into from Sep 27, 2023
Merged

Add founding partners to the about dialog #4040

merged 3 commits into from Sep 27, 2023

Conversation

grantfitzsimmons
Copy link
Contributor

Fixes #4039

@grantfitzsimmons grantfitzsimmons changed the base branch from production to v7.9-dev September 25, 2023 14:02
maxpatiiuk
maxpatiiuk approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the translations for all languages should not contain and - you can use google translate to fix that (or wait on someone in weblate to update the string)

@grantfitzsimmons
Copy link
Contributor Author

the translations for all languages should not contain and - you can use google translate to fix that (or wait on someone in weblate to update the string)

This was something I was hoping Weblate can resolve, but it's more correct than the institution names that were formally translated into other languages (bad).

@grantfitzsimmons grantfitzsimmons added this to the 7.9.1 milestone Sep 26, 2023
@grantfitzsimmons grantfitzsimmons changed the base branch from v7.9-dev to production September 26, 2023 02:34
@grantfitzsimmons grantfitzsimmons merged commit 317632a into production Sep 27, 2023
9 checks passed
@grantfitzsimmons grantfitzsimmons deleted the issue-4039 branch September 27, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@melton-jason melton-jason Awaiting requested review from melton-jason

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.1
Development

Successfully merging this pull request may close these issues.

Add new founding partners to the disclosure text
3 participants
@grantfitzsimmons @maxpatiiuk @CarolineDenis