Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove table name from resource title #4132

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Remove table name from resource title #4132

merged 5 commits into from
Dec 4, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4126

@CarolineDenis CarolineDenis linked an issue Oct 18, 2023 that may be closed by this pull request
Don't display type of resource in title #4126
Closed
@CarolineDenis CarolineDenis added this to the 7.9.3 milestone Oct 18, 2023
maxpatiiuk
maxpatiiuk requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these code changes affect all forms displayed in all places. the fix should be made to only affect the app resource table

@CarolineDenis CarolineDenis marked this pull request as ready for review October 23, 2023 13:32
@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team October 23, 2023 13:32
pashiav
pashiav approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-10-23 at 9 55 47 AM
Screen Shot 2023-10-23 at 9 56 05 AM
Looks good!

maxpatiiuk
maxpatiiuk requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor things

specifyweb/frontend/js_src/lib/components/Forms/BaseResourceView.tsx Outdated Show resolved Hide resolved
specifyweb/frontend/js_src/lib/components/Forms/BaseResourceView.tsx Outdated Show resolved Hide resolved
@carlosmbe carlosmbe requested a review from a team November 22, 2023 20:32
@CarolineDenis CarolineDenis merged commit bc2ea89 into xml-editor Dec 4, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4126 branch December 4, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@carlosmbe carlosmbe carlosmbe approved these changes

@pashiav pashiav pashiav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.4
Development

Successfully merging this pull request may close these issues.

Don't display type of resource in title
4 participants
@CarolineDenis @maxpatiiuk @carlosmbe @pashiav