Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a warning if ther's no available preps #4195

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4075

@CarolineDenis CarolineDenis added this to the 7.9.3 milestone Nov 6, 2023
@CarolineDenis CarolineDenis linked an issue Nov 6, 2023 that may be closed by this pull request
@CarolineDenis CarolineDenis marked this pull request as ready for review November 13, 2023 15:35
@CarolineDenis CarolineDenis requested review from maxpatiiuk and a team November 13, 2023 15:35
Copy link

@bronwyncombs bronwyncombs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't catch if the count of available preps is 0. In other words, if the number of unavailable preps is equal to the total count for a given prep under the cat num entered, the user should be made aware that no loan preparations can be added for that catalog number.

Screen.Recording.2023-11-20.at.1.11.30.PM.mov

Edge case consideration:

For catalog numbers with multiple preparations, there could be variation in the availability status per preparation. We could indicate partial unavailability for that cat number in the response and then leave unavailable preps out of subsequent dialog?

@CarolineDenis
Copy link
Contributor Author

CarolineDenis commented Nov 21, 2023

I see,
the issue was that if a record didn't have preparations we had the "No preparations were found for the following" and nothing else even if one record would have been a part of "No preparations are available..."
I change the code to display both warnings if both present or just the relevant one.
Screenshot 2023-11-21 at 10 05 03 AM
Screenshot 2023-11-21 at 10 05 15 AM
Screenshot 2023-11-21 at 10 05 56 AM

@bronwyncombs ,
we warn the users of unavailable / missing prep for records but it's to them to remove the cat number or not.

@emenslin emenslin self-requested a review December 13, 2023 20:54
Copy link
Collaborator

@emenslin emenslin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I think having the distinction between the preparation being available versus not found will make things more clear to the user.

Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets user know if selected records have no preparations. Looks good!

issue-4075.mov

@CarolineDenis CarolineDenis merged commit 242aa26 into xml-editor Dec 20, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4075 branch December 20, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Warn when entering prep by Cat Num for unavailable preparations
6 participants