-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a warning if ther's no available preps #4195
Conversation
specifyweb/frontend/js_src/lib/components/Interactions/InteractionDialog.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still doesn't catch if the count of available preps is 0. In other words, if the number of unavailable preps is equal to the total count for a given prep under the cat num entered, the user should be made aware that no loan preparations can be added for that catalog number.
Screen.Recording.2023-11-20.at.1.11.30.PM.mov
Edge case consideration:
For catalog numbers with multiple preparations, there could be variation in the availability status per preparation. We could indicate partial unavailability for that cat number in the response and then leave unavailable preps out of subsequent dialog?
I see, @bronwyncombs , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I think having the distinction between the preparation being available versus not found will make things more clear to the user.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets user know if selected records have no preparations. Looks good!
Fixes #4075