Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differenciate list of tables for interactions and data entry #4198

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Differenciate list of tables for interactions and data entry #4198

merged 3 commits into from
Nov 17, 2023

Conversation

CarolineDenis
Copy link
Contributor

Fixes #4197

@CarolineDenis CarolineDenis added this to the 7.9.3 milestone Nov 7, 2023
@CarolineDenis CarolineDenis linked an issue Nov 7, 2023 that may be closed by this pull request
The list of tables for interactions and for data entry is the same. #4197
Closed
maxpatiiuk
maxpatiiuk approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@maxpatiiuk maxpatiiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

@CarolineDenis CarolineDenis marked this pull request as ready for review November 13, 2023 15:43
@CarolineDenis CarolineDenis requested a review from a team November 13, 2023 15:43
grantfitzsimmons
grantfitzsimmons approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@grantfitzsimmons grantfitzsimmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@grantfitzsimmons grantfitzsimmons requested a review from a team November 15, 2023 19:08
pashiav
pashiav approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@pashiav pashiav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Adding and deleting tables in a list only affects its own list.

issue-4197.mov

@CarolineDenis CarolineDenis merged commit b069474 into xml-editor Nov 17, 2023
9 checks passed
@CarolineDenis CarolineDenis deleted the issue-4197 branch November 17, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grantfitzsimmons grantfitzsimmons grantfitzsimmons approved these changes

@maxpatiiuk maxpatiiuk maxpatiiuk approved these changes

@pashiav pashiav pashiav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
General Tester Board
Status: ✅Done
Milestone
7.9.4
Development

Successfully merging this pull request may close these issues.

The list of tables for interactions and for data entry is the same.
5 participants
@CarolineDenis @grantfitzsimmons @maxpatiiuk @pashiav @melton-jason